refactor: remove note screener API #1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantiagoPittella
force-pushed
the
jmunoz-note-screener-cleanup
branch
from
e800bdb to
d7795cb
Compare
fkrause98
reviewed
Jan 12, 2026
| /// Returns the block number at which the note can be consumed. | ||
| /// Returns None if the note is already consumable or never possible | ||
| #[wasm_bindgen(js_name = "consumableAfterBlock")] | ||
| pub fn consumable_after_block(&self) -> Option<u32> { |
Collaborator
There was a problem hiding this comment.
Maybe we should return BlockNumber here
Collaborator
There was a problem hiding this comment.
Might be wrong, but I think that we are using u32 to send block numbers in the web client, right?
Collaborator
There was a problem hiding this comment.
Yeah, I don't think there is a BlockNumber JS model struct. Maybe we can add one but it doesn't seem too critical.
fkrause98
approved these changes
Jan 12, 2026
Collaborator
fkrause98
left a comment
fkrause98
left a comment
There was a problem hiding this comment.
looks good, should we also add tests for the web client exposed models?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked: depends on a
miden-basedep withCloses #1381